corrected the query params for sp api client #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishek-potbhare
requested review from
Copilot,
harishpatankar and
natesalisbury
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the query parameter for the SP API client to match the API documentation specifications.
- Fixes query parameter case from "PostedBefore" to "postedBefore".
Comments suppressed due to low confidence (1)
lib/muffin_man/finances/v20240619.rb:10
- The query parameter key is case-sensitive; it should be 'postedBefore' to match the API documentation.
@query_params["PostedBefore"] = posted_before unless posted_before.nil?
natesalisbury
approved these changes
Apr 23, 2025
abhishek-potbhare
deleted the
Correct_the_amazon_financial_transactions_query_param
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the query param variable for sp-api client
query param should be
postedBeforeinstead of PostedBeforeReferenece:
https://developer-docs.amazon.com/sp-api/docs/finances-api-v2024-06-19-use-case-guide#step-2-identify-the-appropriate-financialeventgroupid
API Provided by amazon:
GET /finances/2024-06-19/transactions?postedAfter=2023-07-26&postedBefore=2023-09-16